Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> Why is this removing the use of the TIMEZONE_GLOBAL macro?
> > It was Peter's suggestion. Once we had a port-specific define, we
> > should use timezone directly, no?
> > #define timezone _timezone
> Oh, I missed that part. A bit risky IMHO --- the macro might expand in
> places you didn't expect/want. TIMEZONE_GLOBAL is unlikely to cause
> any such conflict ...
Agreed. A 'timezone' macro will expand as a structure member, while a
timezone variable will not. Here is a new version that defines a
variable timezone to equal _timezone. This seems cleaner, and removes
the need for TIMEZONE_GLOBAL.
I am still researching the stat() handling in postmaster.c. SRA has a
porting document that I translated from Japanese (via Babelfish) which
looks very helpful.
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2003-04-16 18:00:35|
|Subject: Re: Win32 defines |
|Previous:||From: Peter Eisentraut||Date: 2003-04-16 17:47:18|
|Subject: Re: [PATCHES] the build|