volunteer/peer review request

From: cmr(at)shell(dot)gis(dot)net
To: pgsql-php(at)postgresql(dot)org
Subject: volunteer/peer review request
Date: 2003-03-22 22:09:44
Message-ID: 20030322220944.GB416@ssbeagle
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-php

I trust and value the opinions of the members of this list. Please give
me some constructive criticism on the following code:

http://webdevel.urban.csuohio.edu/lcua_pub/reveal_pub_retrieve.php

Sorry, no control over the colors, if you want plain vanilla:

http://webdevel.urban.csuohio.edu/lcua_pub/pub_retrieve.inc

I have placed comments and cleaned up to the line:

elseif (array_search('submit', $_GET) == "keyword")

Please let me know if this code:

1) makes sense
2) is readable
3) is robust
4) is flexible
5) and anything else you want to tell me (well, anything helpful and
constructive).

I am a sole PHP/postgresql programmer in a college full of people who want to
do projects that would involve this as a model.

This is by no means a finished product, it is simply a beginning tool to
get us all started and acclimated here to internet interfaces to
database backends.

I'm comfortable with PHP, but am no professional. My learning tool is
the documentation that came with both PostgreSQL and PHP, as well as a
few Zend tutorials.

Thank you,
--
--
Chadwick Rolfs

Responses

Browse pgsql-php by date

  From Date Subject
Next Message David Busby 2003-03-22 22:58:56 Re: volunteer/peer review request
Previous Message Adrian Tineo 2003-03-22 10:15:09 Re: Questions Regarding Sessions