Module name: pgsql-server
Changes by: momjian(at)postgresql(dot)org 03/03/20 00:18:15
> > - Move SEQ_MAXVALUE, SEQ_MINVALUE definitions to sequence.h
> > - Add check in pg_dump to see if the value returned is the max /min
> > values and replace with NO MAXVALUE, NO MINVALUE.
> > - Change START and INCREMENT to use START WITH and INCREMENT BY syntax.
> > This makes it a touch easier to port to other databases with sequences
> > (Oracle). PostgreSQL supports both syntaxes already.
> + char bufm,
> + bufx;
> This seems to be an arbitary size. Why not set it to the actual maximum
> + snprintf(bufm, 100, INT64_FORMAT, SEQ_MINVALUE);
> + snprintf(bufx, 100, INT64_FORMAT, SEQ_MAXVALUE);
> sizeof(bufm), sizeof(bufx) is probably the more
> maintenance-friendly/standard way to do it.
I changed the code to use sizeof - but will wait for a response from
Peter before changing the size. It's consistent throughout the sequence
code to be 100 for this purpose.
Rod Taylor <rbt(at)rbt(dot)ca>
pgsql-committers by date
|Next:||From: Bruce Momjian - CVS||Date: 2003-03-20 05:19:27|
|Subject: pgsql-server/src/backend/utils/adt formatting.c|
|Previous:||From: Bruce Momjian - CVS||Date: 2003-03-20 05:06:55|
|Subject: pgsql-server/src/backend/catalog information_s ...|