Skip site navigation (1) Skip section navigation (2)

Re: ON COMMIT temp table handling

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>,Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mike Mascari <mascarm(at)mascari(dot)com>
Subject: Re: ON COMMIT temp table handling
Date: 2002-11-25 02:41:44
Message-ID: 200211250241.gAP2fiB27037@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Gavin Sherry wrote:
> > o  Your code in cluster.c called heap_create_with_catalog() using:
> > 
> > 	isTempNamespace(RelationGetNamespace(OldHeap)),
> > 
> > which returns a boolean, and passes it as the value for 'ateoxact',
> > which is not a boolean.  This call is used to create the new heap file
> > for the cluster operation.  I changed it to ATEOXACTNOOP.
> 
> I haven't looked at the patch because its a bit chaotic here after getting
> back, but it occurs to me that if the cluster is on a temp table we want
> to tell heap_create_with_catalog().

The flag we being passed for the creation of the new heap, which was
going to be deleted anyway when the transaction finished.  Why bother
passing anything special for it?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Gavin SherryDate: 2002-11-25 02:51:29
Subject: Re: ON COMMIT temp table handling
Previous:From: Gavin SherryDate: 2002-11-25 02:17:49
Subject: Re: ON COMMIT temp table handling

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group