Skip site navigation (1) Skip section navigation (2)

Re: inline newNode()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Peter Eisentraut <peter_e(at)gmx(dot)net>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: inline newNode()
Date: 2002-10-12 00:06:44
Message-ID: 200210120006.g9C06i502964@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian wrote:
> Neil Conway wrote:
> > BTW, regarding the newNode() stuff: so is it agreed that Bruce's patch
> > is a performance win without too high of a code bloat / uglification
> > penalty? If so, is it 7.3 or 7.4 material?
> 
> Not sure.  It is a small patch but we normally don't do performance
> fixes during beta unless they are major.

This performance improvement isn't related to a specific user problem
report, so I am going to hold it for 7.4.  At that time we can also
research whether palloc0 should be used in other cases, like palloc
followed by MemSet.

The only issue there is that palloc0 can't optimize away constants used
in the macro so it may be better _not_ to make that change.  Neil, do
you have any performance numbers comparing MemSet with constant vs.
variable parameters, e.g:

	MemSet(ptr, 0, 256)

vs.

	i = 256;
	MemSet(ptr, 0, i)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2002-10-12 00:09:31
Subject: Re: inline newNode()
Previous:From: Bruce MomjianDate: 2002-10-11 23:35:14
Subject: Re: inline newNode()

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-10-12 00:09:31
Subject: Re: inline newNode()
Previous:From: Bruce MomjianDate: 2002-10-11 23:36:51
Subject: Re: INSTALL updates

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group