Skip site navigation (1) Skip section navigation (2)

Re: pltcl and plpython memory leak revisited (fwd)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Nigel J(dot) Andrews" <nandrews(at)investsystems(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pltcl and plpython memory leak revisited (fwd)
Date: 2002-10-09 16:53:06
Message-ID: 200210091653.g99Gr6L24826@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
I thought you were still working on a fix for all languages.


Your patch has been added to the PostgreSQL unapplied patches list at:

	http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Nigel J. Andrews wrote:
> 
> 
> I don't remember seeing any acknowledgement or comments on this. It isn't on
> the unapplied patches list either so I'm assuming it got lost somewhere.
> 
> 
> ---------- Forwarded message ----------
> Date: Fri, 4 Oct 2002 11:50:46 +0100 (BST)
> From: Nigel J. Andrews <nandrews(at)investsystems(dot)co(dot)uk>
> To: pgsql-patches(at)postgresql(dot)org
> Subject: pltcl and plpython memory leak revisited
> 
> 
> 
> I have attached two patches as per:
> 
> 1) pltcl:
> Add SPI_freetuptable() calls to avoid memory leaks (Me + Neil Conway)
> Change sprintf()s to snprintf()s (Neil Conway)
> Remove header files included elsewhere (Neil Conway)
> 
> 2)plpython:
> Add SPI_freetuptable() calls to avoid memory leaks
> Cosemtic change to remove a compiler warning
> 
> 
> Notes:
> 
> I have tested pltcl.c for
>  a) the original leak problem reported for the repeated call of spi_exec in a
> TCL fragment
> and b) the subsequent report resulting from the use of spi_exec -array in a TCL
> fragment.
> 
> The plpython.c patch is exactly the same as that applied to make revision 1.23,
> the plpython_schema.sql and feature.expected sections of the patch are also the
> same as last submited, applied and subsequently reversed out. It remains
> untested by me (other than via make check). However, this should be safe
> provided PyString_FromString() _copies_ the given string to make a PyObject.
> 
> 
> -- 
> Nigel J. Andrews
> Director
> 
> ---
> Logictree Systems Limited
> Computer Consultants

Content-Description: 

[ Attachment, skipping... ]

Content-Description: 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Neil ConwayDate: 2002-10-09 18:01:56
Subject: Re: inline newNode()
Previous:From: Nigel J. AndrewsDate: 2002-10-09 16:31:13
Subject: pltcl and plpython memory leak revisited (fwd)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group