Skip site navigation (1) Skip section navigation (2)

Re: make_greater_string busted

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: make_greater_string busted
Date: 2002-09-20 03:55:36
Message-ID: 200209200355.g8K3taA10973@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Patch applied.  Thanks.

---------------------------------------------------------------------------



Patch applied.  Thanks.

---------------------------------------------------------------------------


Joe Conway wrote:
> Tom Lane wrote:
> > I see in your recent bytea-LIKE patch
> > 
> >         if (datatype != BYTEAOID && pg_database_encoding_max_length() > 1)
> >             len = pg_mbcliplen((const unsigned char *) workstr, len, len - 1);
> >         else
> >             len -= -1;
> > 
> > Surely there's one too many minus signs in that last?
> 
> Bug by Joe; review by Tom; patch attached; please apply.
> 
> Almost sounds like a short poem ;-)
> 
> Joe
> 
> 

> Index: src/backend/utils/adt/selfuncs.c
> ===================================================================
> RCS file: /opt/src/cvs/pgsql-server/src/backend/utils/adt/selfuncs.c,v
> retrieving revision 1.117
> diff -c -r1.117 selfuncs.c
> *** src/backend/utils/adt/selfuncs.c	4 Sep 2002 20:31:29 -0000	1.117
> --- src/backend/utils/adt/selfuncs.c	18 Sep 2002 22:56:28 -0000
> ***************
> *** 3376,3382 ****
>   		if (datatype != BYTEAOID && pg_database_encoding_max_length() > 1)
>   			len = pg_mbcliplen((const unsigned char *) workstr, len, len - 1);
>   		else
> ! 			len -= -1;
>   
>   		if (datatype != BYTEAOID)
>   			workstr[len] = '\0';
> --- 3376,3382 ----
>   		if (datatype != BYTEAOID && pg_database_encoding_max_length() > 1)
>   			len = pg_mbcliplen((const unsigned char *) workstr, len, len - 1);
>   		else
> ! 			len -= 1;
>   
>   		if (datatype != BYTEAOID)
>   			workstr[len] = '\0';

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-09-20 03:57:10
Subject: Re: to_char(FM9.9) bug fix
Previous:From: Bruce MomjianDate: 2002-09-20 03:54:51
Subject: Re: to_char() code cleanup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group