From: | momjian(at)postgresql(dot)org (Bruce Momjian - CVS) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql-server/src/backend commands/prepare.c tc ... |
Date: | 2002-09-20 03:45:08 |
Message-ID: | 20020920034508.BDA4B476472@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: momjian(at)postgresql(dot)org 02/09/19 23:45:08
Modified files:
src/backend/commands: prepare.c
src/backend/tcop: postgres.c
Log message:
> I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the
> moment, but they used to be used; I think the correct response is to
> put back the missing counter increments, not rip out the counters.
Ok, fair enough. It's worth noting that they've been broken for a
while -- for example, the HashJoin counter increments were broken when
you comitted r1.20 of executor/nodeHashJoin.c in May of '99.
I've attached a revised patch that doesn't remove the counters (but
doesn't increment them either: I'm not sure of all the places where
the counter should be incremented).
Neil Conway
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian - CVS | 2002-09-20 03:47:22 | contrib/earthdistance Makefile README.earthdis ... |
Previous Message | Bruce Momjian - CVS | 2002-09-20 03:44:06 | pgsql-server/doc/src/sgml func.sgml |