Skip site navigation (1) Skip section navigation (2)

Re: Bug #758: show_planner_stats does not work for new PREPARE

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, barry(at)xythos(dot)com,pgsql-bugs(at)postgresql(dot)org,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Bug #758: show_planner_stats does not work for new PREPARE
Date: 2002-09-20 03:45:04
Message-ID: 200209200345.g8K3j4005090@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
Patch applied.  Thanks.

---------------------------------------------------------------------------


Neil Conway wrote:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> > I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the
> > moment, but they used to be used; I think the correct response is to
> > put back the missing counter increments, not rip out the counters.
> 
> Ok, fair enough. It's worth noting that they've been broken for a
> while -- for example, the HashJoin counter increments were broken when
> you comitted r1.20 of executor/nodeHashJoin.c in May of '99.
> 
> I've attached a revised patch that doesn't remove the counters (but
> doesn't increment them either: I'm not sure of all the places where
> the counter should be incremented).
> 
> Cheers,
> 
> Neil
> 
> -- 
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-bugs by date

Next:From: Yury BokhoncovichDate: 2002-09-20 06:38:33
Subject: Re: Bug #770: 7.2.1 --> 7.2.2 =? Problems with speed
Previous:From: jld123Date: 2002-09-20 01:32:39
Subject: Fix for PSQL 7.2.2 doesn't compile on OS X 10.2

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-09-20 03:47:06
Subject: Re: earthdistance fixes, but no cube stuff
Previous:From: Bruce MomjianDate: 2002-09-20 03:43:56
Subject: Re: Doc patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group