Skip site navigation (1) Skip section navigation (2)

Re: bug in COPY

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>,PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bug in COPY
Date: 2002-08-27 20:30:53
Message-ID: 200208272030.g7RKUsh12301@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Patch applied.

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> The exclamation point seems inappropriate.  Perhaps "zero-length input"
> >> would be better than "string" also.
> 
> > I copied the other test case:
> 
> >     if (s == (char *) NULL)
> >         elog(ERROR, "pg_atoi: NULL pointer!"); 
> 
> Well, the NULL-pointer test might equally well be coded as an Assert:
> it's to catch backend coding errors, not cases of incorrect user input.
> So the exclamation point there didn't bother me.
> 
> > I removed them both '!'.
> 
> If you like.  But the two conditions are not comparable.
> 
> 			regards, tom lane
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2002-08-27 20:33:30
Subject: Re: bug in COPY
Previous:From: Bruce MomjianDate: 2002-08-27 20:24:48
Subject: Re: bug in COPY

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group