Skip site navigation (1) Skip section navigation (2)

Re: fmtId() and pg_dump

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fmtId() and pg_dump
Date: 2002-07-30 18:46:48
Message-ID: 200207301846.g6UIkmf07260@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

	http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Neil Conway wrote:
> The attached patch implements the scheme outlined on -hackers a little
> while ago for reducing the usage of fmtId() in pg_dump. This is just
> a "proof of concept" -- I added a simple wrapper over
> appendPQExpBuffer() that takes an extra formatting sequence. The
> implementation is pretty trivial -- the assumption is made that
> 
>     (a) all printf-like formatting sequences consist of a '%' followed
>         by a single character
> 
>     (b) any occurance of a '%' is a part of a formatting string
> 
> I've converted a few of the places where fmtId() is used over to the new
> syntax. The reason I'm posting the patch is to get some feedback:
> is this a better method can just calling fmtId()?
> 
> If so, I'll add some comments, convert all the code to use the wrapper
> as necessary, and think up a better name for the wrapper function.
> 
> Cheers,
> 
> Neil
> 
> -- 
> Neil Conway <neilconway(at)rogers(dot)com>
> PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
> 
> http://www.postgresql.org/users-lounge/docs/faq.html

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-07-30 18:46:58
Subject: Re: regression test fix
Previous:From: Bruce MomjianDate: 2002-07-30 16:55:45
Subject: Re: remove recipe code

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group