Re: CLUSTER patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)atentus(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: CLUSTER patch
Date: 2002-07-18 15:11:53
Message-ID: 200207181511.g6IFBro12021@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Doc patch mentions problem with dependency after CLUSTER. Patch removed
from queue.

---------------------------------------------------------------------------

Alvaro Herrera wrote:
> Tom Lane dijo:
>
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > This case is actually more complicated because after the swap, pg_class
> > > still says thisxactonly but the relfilenode points to non-thisactonly
> > > buffers, and via versa.
> >
> > pg_class doesn't say anything (if it did, we could make relcache.c
> > track it).
> >
> > But yes, the problem is that myxactonly has to line up with where the
> > buffers are stored. As I mentioned, I think it would work to flush out
> > all buffers for both rels before doing the swap.
>
> It does indeed work. Actually, I tried to do that before, but the fact
> that RelationFlushBuffers requires a firstDelBlock made me turn around.
>
> I attach a new patch against current cvs HEAD. It works as far as I've
> tested it, but I may be missing some cases. I'll post a documentation
> patch later if this gets applied.
>
> --
> Alvaro Herrera (<alvherre[a]atentus.com>)
> "Some men are heterosexual, and some are bisexual, and some
> men don't think about sex at all... they become lawyers" (Woody Allen)

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-07-18 17:02:01 Re: Between Node
Previous Message Bruce Momjian 2002-07-18 15:10:38 Re: CLUSTER patch