Re: utils C files

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: utils C files
Date: 2002-07-18 04:35:26
Message-ID: 200207180435.g6I4ZQw07535@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > How is this any better than just mentioning the *.o file and letting the
> > default rules compile it. I don't understand how linking to the current
> > directory gets us anything. Now, if you did a 'make -C dir target' that
> > would be different.
>
> The whole point of the pushups for libpq is that we DON'T want the
> default rules. We need to compile it PIC so that it can go into a
> shared library. This will not be the same object file built in the
> ports directory.

OK, I have moved the files to src/port. Would people like this rule
added to Makefile.global.in so that any usage of src/port/*.c files will
compile in the local directory?

ifdef SNPRINTF
$(basename $(notdir $(SNPRINTF))).c: $(basename $(SNPRINTF)).c
rm -f $@ && $(LN_S) $< .
endif

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-07-18 04:55:40 Re: utils C files
Previous Message Bruce Momjian 2002-07-18 03:59:28 Re: utils C files

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-07-18 04:40:50 Re: Table Function API patch (was Re: another SRF question)
Previous Message Bruce Momjian 2002-07-18 03:59:28 Re: utils C files