Skip site navigation (1) Skip section navigation (2)

Re: psql Segfaults shortly after doing variable substitution

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "William K(dot) Volkman" <wkvpsql(at)netshark(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: psql Segfaults shortly after doing variable substitution
Date: 2002-06-15 19:37:50
Message-ID: 200206151937.g5FJboj05955@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Patch applied.  Thanks.

---------------------------------------------------------------------------



William K. Volkman wrote:
> Noted with versions 7.0.3, 7.1.3, and 7.2.1:
> 
> The psql interpreter becomes unstable if variable substitutions
> are used.  The debugger GDB was unable to help however mpatrol
> reports that the sprintf at mainloop.c:389 is steping one byte
> farther than the allocation.
> 
> Patch file attached.
> 
> Cheers,
> William.
> 
> 
> 

> --- postgresql-7.1.3/src/bin/psql/mainloop.c~	Mon Mar 26 08:18:51 2001
> +++ postgresql-7.1.3/src/bin/psql/mainloop.c	Tue May 28 15:00:12 2002
> @@ -379,7 +379,8 @@
>  				{
>  					out_length = strlen(value);
>  
> -					new = malloc(len + out_length - (1 + in_length) + 1);
> +					/* Allow for 'after' character also 2002-05-27 */
> +					new = malloc(len + out_length - (1 + in_length) + 1 + 1);
>  					if (!new)
>  					{
>  						psql_error("out of memory\n");

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-06-15 19:39:54
Subject: Re: macaddr format fix
Previous:From: Bruce MomjianDate: 2002-06-15 19:16:19
Subject: Re: libpq++ fixes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group