On Thu, May 02, 2002 at 05:42:13PM -0400, Tom Lane wrote:
> If we do this, we should use double quotes "...". A double-quoted
> string is an identifier, a single-quoted string is a literal; and
> it doesn't help anyone for the system's messages to get it backwards.
> (I've been intending for awhile to fix all the elog messages that get
> this wrong.)
> How would you feel about quoting only if necessary
> (cf. quote_identifier)?
That would work nicely. I didn't put the call to quote_identifier inside
the stringStringInfo macro.
> > Aliases are explicitly labelled.
> I think that's just noise. The explain output is verbose enough without
> adding noise words...
Hmm.. I kinda like having it there, but you are right in that it isn't
neccessary and doesn't add much. I'll live with it being out.
Liam Stewart :: Red Hat Canada, Ltd. :: liams(at)redhat(dot)com
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2002-05-03 15:58:42|
|Subject: Re: small explain patch |
|Previous:||From: Tom Lane||Date: 2002-05-02 21:45:13|
|Subject: Re: small s_lock.c bug |