Skip site navigation (1) Skip section navigation (2)

Re: regression tests for ALTER TABLE ... DEFAULT

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>,Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: regression tests for ALTER TABLE ... DEFAULT
Date: 2002-04-24 05:06:42
Message-ID: 200204240506.g3O56ge10896@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> Don't you ever run the tests before checking stuff in?
> 
> > ... Nope.  I do it once a batch is checked in.  I assume submitters have
> > already done it.  Too much work.
> 
> Whether or not you assume that the submitter ran regress tests, it's
> unsafe to assume that a several-days-old patch is still good against
> current CVS tip.  Especially not when you get merge failures, as you
> certainly must have in this case.

Proper patch testing requires initdb and regression tests.  I do those
at the end of a batch of patches, not for each one.

If you want to agitate that there are problems with my patch
application, go ahead.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-04-24 05:12:36
Subject: Re: unknownin/out patch (was [HACKERS] PQescapeBytea is not
Previous:From: Tom LaneDate: 2002-04-24 05:02:49
Subject: Re: regression tests for ALTER TABLE ... DEFAULT

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group