Re: make BufferGetBlockNumber() a macro

From: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: make BufferGetBlockNumber() a macro
Date: 2002-04-02 06:04:32
Message-ID: 20020402010432.072c65b0.nconway@klamath.dyndns.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Mon, 01 Apr 2002 20:50:27 -0500
"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> writes:
> > C's information hiding is weak enough that you need to rely on the
> > client programmer to exercise good judgement anyway;
>
> This is not a good argument for making the hiding even weaker. I still
> object to this patch.

Ok. The attached trivial patch removes some obsolete or incoherent
comments and fixes an assertion in BufferGetBlockNumber. The
macro-ization of BufferGetBlockNumber is _not_ included.

Please apply.

Cheers,

Neil

--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC

Attachment Content-Type Size
block_macro.patch application/octet-stream 2.4 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Nicolas Bazin 2002-04-02 06:35:02 please apply patch - build on Unixware with GCC
Previous Message Nicolas Bazin 2002-04-02 04:34:01 please apply patch