Skip site navigation (1) Skip section navigation (2)

Re: truncate cleanup

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: truncate cleanup
Date: 2002-03-14 22:43:27
Message-ID: (view raw or whole thread)
Lists: pgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

I will try to apply it within the next 48 hours.


Neil Conway wrote:
> The attached patch cleans up the implementation of the TRUNCATE command;
> in the current code, the authentication logic (check user, check the
> relation we're operating on, etc) is done in tcop/utility.c, whereas the
> actual TRUNCATE command in done in TruncateRelation() in
> commands/createinh.c (which is really just a wrapper over
> heap_truncate() in catalog/heap.c). This patch moves the authentication
> logic into TruncateRelation(), as well as making some minor code
> cleanups.
> FWIW, I'm not really sure why TruncateRelation() is in
> commands/createinh.c to begin with; if there is a preference, I can
> remove TruncateRelation() altogether and move everything into
> heap_truncate().
> Cheers,
> Neil
> -- 
> Neil Conway <neilconway(at)rogers(dot)com>
> PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-03-14 22:44:52
Subject: Re: ALTER TABLE OWNER: handle toast
Previous:From: Bruce MomjianDate: 2002-03-14 22:35:53
Subject: Re: Added Encoding

Privacy Policy | About PostgreSQL
Copyright © 1996-2015 The PostgreSQL Global Development Group