psql: backslash fix

From: nconway(at)klamath(dot)dyndns(dot)org (Neil Conway)
To: pgsql-patches(at)postgresql(dot)org
Subject: psql: backslash fix
Date: 2002-03-11 21:29:49
Message-ID: 20020311212949.GA6215@klamath.dyndns.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hi all,

Recently, I reported on -hackers a strange case where psql wouldn't
reset it's query buffer properly on a malformed backslash command, which
would mean that the next query wouldn't be parsed properly. For
instance:

nconway=> select foo\\bar;
Invalid command \. Try \? for help.
nconway-> select 1;
ERROR: parser: parse error at or near "select"

I've attached a patch which fixes this. I'm not sure if it is the
"right" way to fix it, but it resolves the situation discribed above, at
least. The new behavior is:

nconway=> select foo\\bar;
Invalid command \. Try \? for help.
ERROR: Attribute 'foo' not found
nconway=> select 1;
?column?
----------
1
(1 row)

Unless anyone sees any problems, please apply.

Cheers,

Neil

--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC

Attachment Content-Type Size
psql-fix.patch text/plain 1.3 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2002-03-11 22:08:29 Re: psql: backslash fix
Previous Message Bruce Momjian 2002-03-11 20:52:51 Re: Domain Support -- another round