Re: postgresql-7.2b3-betterquote.patch

I am getting a Python compile error with this patch attached on the
function call PySequence_Size():

gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -O0 -Wall -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wcast-align -fpic -I../../../src/interfaces/libpq -I../../../src/include -I/usr/local/include/readline -I/usr/contrib/include -I/usr/contrib/include/python1.5 -c -o pgmodule.o pgmodule.c
pgmodule.c: In function `pgpy_quote_fast':
pgmodule.c:3166: warning: implicit declaration of function `PySequence_Size'
pgmodule.c:3191: warning: passing arg 2 of `PyTuple_SetItem' makes integer from pointer without a cast
pgmodule.c:3191: too few arguments to function `PyTuple_SetItem'
pgmodule.c:3194: warning: implicit declaration of function `_PyString_Join'
pgmodule.c:3194: warning: assignment makes pointer from integer without a cast
pgmodule.c:3197: warning: implicit declaration of function `PyString_FromFormat'
pgmodule.c:3197: warning: assignment makes pointer from integer without a cast
pgmodule.c: In function `pgpy_quoteparams_fast':
pgmodule.c:3224: warning: passing arg 1 of `PyArg_ParseTuple' from incompatible pointer type
pgmodule.c:3224: warning: passing arg 2 of `PyArg_ParseTuple' from incompatible pointer type
gmake: *** [pgmodule.o] Error 1

I am backing out this patch. Please resubmit with this corrected. Thanks.

I am running Python 1.5.

---------------------------------------------------------------------------

pgman wrote:
>
> Patch applied. Thanks.
>
> ---------------------------------------------------------------------------
>
>
> Elliot Lee wrote:
> > This patch to the python bindings adds C versions of the often-used query
> > args quoting routines, as well as support for quoting lists e.g.
> > dbc.execute("SELECT * FROM foo WHERE blah IN %s", ([1,2,3],))
> >
> > Please consider incorporating this patch into postgresql 7.2,
> > -- Elliot
>
> Content-Description:
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026