Skip site navigation (1) Skip section navigation (2)

guc

From: Liam Stewart <liams(at)redhat(dot)com>
To: PostgreSQL Patches List <pgsql-patches(at)postgresql(dot)org>
Subject: guc
Date: 2002-01-17 21:54:34
Message-ID: 20020117165433.C19161@redhat.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
I was playing around with adding a couple new SET commands (REAL_FORMAT
and DOUBLE_PRECISION_FORMAT as per todo list item) and I ended up
playing with GUC a bit.

I've cleaned it up a bit - most of the changes should be fairly
self-explanitory from the patch. Some of the configuration options
handled in variable.c (so far, server_encoding and seed) have been moved
into guc.c and are handled by GUC. Moving them in required adding a
couple of fields to config_generic and friends - a read_only field and a
display_proc field (hook for custom SHOW messages). I've removed
GetConfigOption() and replaced it with ShowConfigOption() which does an
elog(NOTICE) instead of returning a string.

When setting REAL_FORMAT and DOUBLE_PRECISION_FORMAT, the printf-style
format string should be checked for certain things: 

  - field width of "*" is not allowed
  - precision of ".*" is not allowed
  - all conversion specifiers except "s" and "n" are allowed
  - only one conversion specification other than %% and variations is
    allowed

Does this seem reasonable to people? I haven't written a function to
check those yet.. will do soon.

This patch isn't complete yet so don't append it to the pending patches
list, Bruce.

Liam

-- 
Liam Stewart :: Red Hat Canada, Ltd. :: liams(at)redhat(dot)com

Responses

  • Re: [PATCHES] guc at 2002-01-17 22:35:24 from Peter Eisentraut
  • Re: guc at 2002-01-25 02:09:37 from Bruce Momjian
  • Re: guc at 2002-02-25 03:55:54 from Bruce Momjian

pgsql-hackers by date

Next:From: Tom LaneDate: 2002-01-17 22:27:05
Subject: Re: Bug in pg_dump/restore -o
Previous:From: Tom LaneDate: 2002-01-17 21:47:28
Subject: Re: tuptoaster.c must *not* use SnapshotAny

pgsql-patches by date

Next:From: Elliot LeeDate: 2002-01-17 22:04:09
Subject: postgresql-7.2b3-betterquote.patch
Previous:From: Brent VernerDate: 2002-01-17 12:28:45
Subject: Re: COPY when 'filename' is a directory

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group