Re: Patches for AIX builds..

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rick Flower <Richard(dot)Flower(at)quest(dot)com>
Cc: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Patches for AIX builds..
Date: 2002-01-14 15:33:51
Message-ID: 200201141533.g0EFXpS15050@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Rick Flower wrote:
> Hi.. (hopefully this didn't get MIME'ized/HTML'ized by Outlook 2k!)
>
> I picked up the latest CVS snapshot this afternoon and have made some
> changes
> that were necessary for building PostgreSQL on AIX 4.33 using the VisualAge
> C++
> compiler (version 5). I'm not sure if my format for diff's is proper, but
> I'll
> do it in what I *think* is correct.. These are the output from using "cvs
> diff"
> All of the changes are very short :

OK, we are very close to final so I can only make the most modest
changes unless another AIX person can comment:

FYI, we usually need context diffs (diff -c), but these are OK for this
purpose.

> Index: src/Makefile.shlib
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/Makefile.shlib,v
> retrieving revision 1.56
> diff -r1.56 Makefile.shlib
> 323c323
> < $(COMPILER) -Wl,-H512 -Wl,-bM:SRE
> -Wl,-bI:$(top_builddir)/src/backend/$(POSTGRES_IMP)
> -Wl,-bE:lib$(NAME)$(EXPSUFF) -o $@ $< $(LDFLAGS) $(SHLIB_LINK) $(LDFLAGS_SL)
> ---
> > $(COMPILER) -Wl,-H512 -Wl,-bM:SRE
> -Wl,-bI:$(top_builddir)/src/backend/$(POSTGRES_IMP)
> -Wl,-bE:lib$(NAME)$(EXPSUFF) -o $@ $< $(LDFLAGS) $(SHLIB_LINK) -brtl
> $(LDFLAGS_SL)

Sorry, can't apply this one without AIX comment from someone else.

> Index: src/interfaces/odbc/misc.c
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/interfaces/odbc/misc.c,v
> retrieving revision 1.26
> diff -r1.26 misc.c
> 19a20
> > #include <stdlib.h>

This one is safe; added.

> Index: src/interfaces/odbc/statement.h
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/interfaces/odbc/statement.h,v
> retrieving revision 1.33
> diff -r1.33 statement.h
> 105c105
> < STMT_PARSE_FATAL,
> ---
> > STMT_PARSE_FATAL
> 113c113
> < STMT_FETCH_EXTENDED,
> ---
> > STMT_FETCH_EXTENDED
>

This one is also safe, trailing comma in structure removed; done.

> Index: src/template/aix
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/template/aix,v
> retrieving revision 1.9
> diff -r1.9 aix
> 4c4
> < CFLAGS='-O2 -qmaxmem=16384 -qsrcmsg -qlonglong'
> ---
> > CFLAGS='-O2 -qchars=signed -qmaxmem=16384 -qsrcmsg -qlonglong'

Need AIX comment.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-01-14 17:39:42 Re: Patches for AIX builds..
Previous Message Justin Clift 2002-01-14 08:46:33 Re: Search page needs "patches"