Skip site navigation (1) Skip section navigation (2)

Re: More problem with scripts

From: Brent Verner <brent(at)rcfile(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: More problem with scripts
Date: 2002-01-04 21:59:50
Message-ID: 20020104215950.GA39597@rcfile.org (view raw or flat)
Thread:
Lists: pgsql-hackers
[2002-01-04 00:34] Bruce Momjian said:
| Brent Verner wrote:
| > [2002-01-03 23:33] Peter Eisentraut said:
| > | > Brent Verner wrote:
| > | > > [2002-01-03 14:19] Bruce Momjian said:
| > | > > | 
| > | > > | Actually, we can just do:
| > 
| > | > > +1
| > | > > 
| > | > >   I can't see a reason to /not/ fix something this simple for the 7.2 
| > | > > release.  In general, I think it's best to fix things like this[1]
| > | > > "on sight" as opposed to queueing them in TODO where they /might/ sit
| > | > > untouched through another release cycle.
| > | > > 
| > | > > [1] meaning problems that require little effort to fix, and whose
| > | > >     solutions are /very/ localized.
| > | > 
| > | > OK, one more +1 and I will get to it.
| > | 
| > | -4
| 
| OK, here's the patch.  Seems createdb wasn't properly handling the db
| comment (arg code now similar to createlang), createlang dbname being
| optional wasn't documented in --help, and vacuumdb wasn't handlling an
| optional dbname.  I added the required checks so extra arguments report
| a failure:
| 	
| 	$ dropdb lkjas asdfljk test
| 	dropdb: invalid option: asdfljk
| 	Try 'dropdb --help' for more information.

This looks good to me.

thanks.
  brent

-- 
"Develop your talent, man, and leave the world something. Records are 
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing."  -- Duane Allman

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2002-01-04 23:12:44
Subject: Re: O_DIRECT use
Previous:From: Tom LaneDate: 2002-01-04 21:57:06
Subject: Re: O_DIRECT use

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group