Skip site navigation (1) Skip section navigation (2)

Re: More problem with scripts

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Brent Verner <brent(at)rcfile(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: More problem with scripts
Date: 2002-01-04 05:34:53
Message-ID: 200201040534.g045YrI26643@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Brent Verner wrote:
> [2002-01-03 23:33] Peter Eisentraut said:
> | > Brent Verner wrote:
> | > > [2002-01-03 14:19] Bruce Momjian said:
> | > > | 
> | > > | Actually, we can just do:
> 
> | > > +1
> | > > 
> | > >   I can't see a reason to /not/ fix something this simple for the 7.2 
> | > > release.  In general, I think it's best to fix things like this[1]
> | > > "on sight" as opposed to queueing them in TODO where they /might/ sit
> | > > untouched through another release cycle.
> | > > 
> | > > [1] meaning problems that require little effort to fix, and whose
> | > >     solutions are /very/ localized.
> | > 
> | > OK, one more +1 and I will get to it.
> | 
> | -4

OK, here's the patch.  Seems createdb wasn't properly handling the db
comment (arg code now similar to createlang), createlang dbname being
optional wasn't documented in --help, and vacuumdb wasn't handlling an
optional dbname.  I added the required checks so extra arguments report
a failure:
	
	$ dropdb lkjas asdfljk test
	dropdb: invalid option: asdfljk
	Try 'dropdb --help' for more information.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2002-01-04 05:45:03
Subject: Re: PGSQL - FAQ 4.1
Previous:From: Bruce MomjianDate: 2002-01-04 05:02:29
Subject: Re: LWLock contention: I think I understand the problem

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group