Christopher Kings-Lynne wrote:
> Hi,
> 
> Tom - you mentioned recently that your changes to the parser mean that my
> add unique code is deprecated.  You also mentioned that your changes will
> make ADD PRIMARY KEY also work.
> 
> If that is true, then the fact that both of these work should be put in the
> HISTORY file (ADD UNIQUE already is) and documented on the ALTER TABLE docs.
> This should probably be done before a release.

Added to HISTORY and release.sgml.  I don't see any mention in
alter_table.sgml.

> Also, I don't know if this should be done so late in the cycle, but the ADD
> UNIQUE regression test I added should probably be copied as an ADD PRIMARY
> KEY regression test...

Can you send over a patch?  I am not sure what you are suggesting here.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

• ADD PRIMARY KEY and ADD UNIQUE at 2001-12-13 02:06:20 from Christopher Kings-Lynne

pgsql-hackers by date

Next:	From: Bruce Momjian	Date: 2002-01-03 05:53:54
	Subject: Re: Possible bug in vacuum redo
Previous:	From: Tom Lane	Date: 2002-01-03 04:05:23
	Subject: Re: bug in join?