Skip site navigation (1) Skip section navigation (2)

Re: SunOS patch for memcmp()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: lockhart(at)fourpalms(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, peter_e(at)gmx(dot)net, pgsql-patches(at)postgresql(dot)org
Subject: Re: SunOS patch for memcmp()
Date: 2001-12-20 21:21:25
Message-ID: 200112202121.fBKLLPr22060@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> > > > OK, what do people want with the memcmp() fix?  Tatsuo and I say apply,
> > > > Tom is yes, or was,
> > > Still is.  I don't want to gin up a strtol fix from scratch at this
> > > late date in our cycle, but I think that the memcmp fix is safe.
> > OK, good.  I will put the strtol on my list for 7.3.  The memcmp is much
> > more significant.  Overflow is minor for most uses.
> 
> Right. I'll plop SunOS back into the list of supported platforms for
> this release. Thanks for the work Tatsuo and Bruce!

OK, I have four votes for the patch, and one against.  I will apply it
now.  We can consider SunOS supported.  There is the the problem that
overflow is not detected by strtol but that is not a critical feature:

  INSERT INTO INT4_TBL(f1) VALUES ('1000000000000');
- ERROR:  pg_atoi: error reading "1000000000000": Numerical result out of range

I will try to get that fixed for 7.3.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2001-12-20 22:00:57
Subject: Re: TOAST performance (was Re: [GENERAL] Delete Performance)
Previous:From: Karel ZakDate: 2001-12-20 18:48:16
Subject: Re: tkConfig.sh vs. ./configure

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-12-20 21:31:45
Subject: Re: SunOS patch for memcmp()
Previous:From: Karel ZakDate: 2001-12-20 18:31:30
Subject: Czech NLS

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group