Re: SunOS patch for memcmp()

> Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
> > Ok. I have tested patches from Bruce. Now tests for bit passed.
> > Remaining issues seem that strtol() is broken on SunOS4, not detecting
> > an overflow, which causes int4 and some of other tests failure.
>
> Looks like you might also want to use horology-no-DST-before-1970.out.
>
> > Should we use our own strtol()?
>
> Mumble. The memcmp fix was all from well-tested parts, but I don't
> think we have a canned test for strtol breakage available. Also,
> I believe that the SunOS strtol lossage has been known and tolerated
> in previous Postgres releases. Since it's not a regression, I'm going
> to change sides and vote with Peter: let's not fix this one now.

OK, what do people want with the memcmp() fix? Tatsuo and I say apply,
Tom is yes, or was, and Peter is probably no. Can I have more vote
either way? I have already posted the patch.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026