Re: SunOS patch for memcmp()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: SunOS patch for memcmp()
Date: 2001-12-17 07:43:48
Message-ID: 200112170743.fBH7hmI18466@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> > > SunOS Tatsuo Ishii
> > > Are we giving up on this one? Still relevant?
> >
> > What should we do? The only remaining issue is a non-8-bit-clean
> > memcmp, which seems pretty easy to fix it.
>
> OK, here is a patch to allow SunOS to pass the regression tests. One
> attachment is the patch, which is quite small except that the line
> numbers in configure changed with autoconf, and that bloated the patch.
> The second attachment is the file memcmp.c which should be placed in
> src/utils. I got this from NetBSD.

OK, here is an even better, smaller version. You need to put memcmp.c
in src/backend/port, rather than src/utils. Because memcmp.c is used
only by the backend, it seems it belongs properly in ports. strdup() is
in utils because it is used by PG client apps.

Again, configure line number changes bloat the patch.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 76.2 KB
unknown_filename text/plain 862 bytes

Browse pgsql-patches by date

  From Date Subject
Next Message Zeugswetter Andreas SB SD 2001-12-17 13:43:10 Re: [HACKERS] Problem compiling postgres sql --with-tcl
Previous Message Bruce Momjian 2001-12-17 05:30:59 SunOS patch for memcmp()