Re: system catalog relation of a table and a serial sequence

From: Brent Verner <brent(at)rcfile(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: system catalog relation of a table and a serial sequence
Date: 2001-12-16 11:30:21
Message-ID: 20011216113021.GA9061@rcfile.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

[2001-12-16 00:42] Tom Lane said:
| Brent Verner <brent(at)rcfile(dot)org> writes:
| > How about strtok_r? I /really/ like the fact that strtok will
| > eat either of the tokens ['"] that might be around the sequence
| > name... just call me lazy :-)
|
| That behavior creates one of the "corner cases" I was alluding to.
| Shall I leave the difficulty as an exercise for the student?

Ok... I ended up working longer than I'd thought :-)

* no strtok were used in this patch. ;-)
* Handles both serial-sequences and user-sequences referenced in
nextval(...) default column defs.
* Loop over tables so we can check wildcard table name in the future
per your suggestion. I've only noted a TODO: regarding the wildcard
matching.
* Instead of using a NULL terminated char** array to hold the collected
sequence names, I put in a simple strarray ADT -- mostly so I could
have the strarrayContains() test to call from the conditional around
dumpSequence(). If this is just dumb, I'll replace it with a simple
char** implementation. Did I overlook some utility funcs in the
PG source that already does this? If so, I'll gladly use those.
* Patch is really attached :-P

comments?

tired.
b

--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing." -- Duane Allman

Attachment Content-Type Size
pg_dump.serial.diff.2 text/plain 7.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Buttafuoco 2001-12-16 14:12:14 Re: Bulkloading using COPY - ignore duplicates?
Previous Message Andrew McMillan 2001-12-16 07:25:00 Re: [HACKERS] system catalog relation of a table and a

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2001-12-16 22:23:56 Re: [PATCHES] system catalog relation of a table and a
Previous Message Andrew McMillan 2001-12-16 07:25:00 Re: [HACKERS] system catalog relation of a table and a