Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)

From: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
To: pgman(at)candle(dot)pha(dot)pa(dot)us
Cc: ZeugswetterA(at)spardat(dot)at, tgl(at)sss(dot)pgh(dot)pa(dot)us, peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)
Date: 2001-11-16 04:37:51
Message-ID: 20011116133751O.t-ishii@sra.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
I wanted to test the new patches on AIX 5L but the cvs server seem to
reject me (it worked till yesterday). Sigh.
--
Tatsuo Ishii

> OK, I backed out your previous patch and applied this one.
> 
> Thanks.
> 
> ---------------------------------------------------------------------------
> 
> > 
> > > "Zeugswetter Andreas SB SD" <ZeugswetterA(at)spardat(dot)at> writes:
> > > 
> > >   /* Plain "long int" fits, use it */
> > > + #if SIZEOF_INT8 == 0
> > >   typedef long int int64;
> > > + #endif
> > > + #if SIZEOF_UINT8 == 0
> > >   typedef unsigned long int uint64;
> > > + #endif
> > >   
> > > 
> > > This coding appears to assume "if the platform defines int8, then
> > > it will define int64 as well".  Seems mighty fragile to me.
> > 
> > Well the absolute correct solution would involve all of:
> > int8, int16, int32, int64 and separately uint8, uint16, uint32, uint64
> > 
> > The previous patch grouped:
> > int8, int16 and int32
> > uint8, uint16 and uint32
> > int64 and uint64  <-- this grouping is wrong on AIX 4.3.3 and below
> > 
> > If you prefer to make 4 groups out of this you could apply this patch.
> > 
> > Andreas
> 
> Content-Description: int8-newpatch2
> 
> [ Attachment, skipping... ]
> 
> -- 
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
> 

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2001-11-16 04:50:15
Subject: Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)
Previous:From: Tom LaneDate: 2001-11-16 04:12:24
Subject: Re: Call for objections: revision of keyword classification

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-11-16 04:50:15
Subject: Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)
Previous:From: Tom LaneDate: 2001-11-16 04:12:24
Subject: Re: Call for objections: revision of keyword classification

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group