Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Cc: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
Subject: Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)
Date: 2001-11-15 02:26:05
Message-ID: 200111150226.fAF2Q5M28951@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
> > > The check for int64 and uint64 has to be separated, my AIX
> > > has: int8, int16, int32, int64
> > > but not: uint8, uint16, uint32, uint64
> >
> > This would be an incremental patch to Peter's, but as I said I have not
> > been able to check configure itself. (The rest works, needless to say)
> > I am actually very suspicious whether the configure trick
> > AC_CHECK_SIZEOF(int8, 0) will work, because they only get defined
> > with _ALL_SOURCE defined and inttypes.h included.
> >
> > Previous patch included just in case.
> > Tatsuo would you be so kind as to check this, that would be great ?
> 
> Peter's patches could not be applied to the current and I cannot test
> your patches too.
> 
> [t-ishii(at)srapc1474 pgsql]$ patch -b -p2 < ~/int8-patch
> missing header for context diff at line 3 of patch
> patching file configure.in
> patching file src/include/pg_config.h.in
> patching file src/include/c.h
> Hunk #1 FAILED at 204.
> Hunk #2 FAILED at 216.
> Hunk #3 FAILED at 266.
> 3 out of 3 hunks FAILED -- saving rejects to file src/include/c.h.rej

My guess is that pgindent has modified c.h.  Tatsuo, if you send me the
patch, I will manually apply it to current CVS and send you a new
version of the patch for testing.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-11-15 02:59:00
Subject: Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)
Previous:From: Tatsuo IshiiDate: 2001-11-15 01:22:00
Subject: Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group