Re: ecpg - GRANT bug

I agree we need to find out why the line number is off rather than
covering up the problem. Patch rejected.

---------------------------------------------------------------------------

> Lee Kindness writes:
> > Patch below, it changes:
> > 1. A number of mmerror(ET_ERROR) to mmerror(ET_NOTICE), passing on
> > the (currently) unsupported options to the backend with warning.
> > 2. Standardises warning messages in such cases.
> > 3. Corrects typo in passing of 'CREATE FUNCTION/INOUT' parameter.
>
> And the patch below corrects a pet peeve I have with ecpg, all errors
> and warnings are output with a line number one less than reality...
>
> Lee.
>
> *** ./interfaces/ecpg/preproc/preproc.y.orig Tue Oct 16 10:19:27 2001
> --- ./interfaces/ecpg/preproc/preproc.y Tue Oct 16 10:19:49 2001
> ***************
> *** 36,49 ****
> switch(type)
> {
> case ET_NOTICE:
> ! fprintf(stderr, "%s:%d: WARNING: %s\n", input_filename, yylineno, error);
> break;
> case ET_ERROR:
> ! fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename, yylineno, error);
> ret_value = PARSE_ERROR;
> break;
> case ET_FATAL:
> ! fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename, yylineno, error);
> exit(PARSE_ERROR);
> }
> }
> --- 36,52 ----
> switch(type)
> {
> case ET_NOTICE:
> ! fprintf(stderr, "%s:%d: WARNING: %s\n", input_filename,
> ! yylineno + 1, error);
> break;
> case ET_ERROR:
> ! fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename,
> ! yylineno + 1, error);
> ret_value = PARSE_ERROR;
> break;
> case ET_FATAL:
> ! fprintf(stderr, "%s:%d: ERROR: %s\n", input_filename,
> ! yylineno + 1, error);
> exit(PARSE_ERROR);
> }
> }
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026