Skip site navigation (1) Skip section navigation (2)

Re: More fixes for missing double quotes in the shell scripts

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin <justin(at)postgresql(dot)org>, PostgreSQL Patches Mailing List <pgsql-patches(at)postgresql(dot)org>
Subject: Re: More fixes for missing double quotes in the shell scripts
Date: 2001-09-28 19:28:20
Message-ID: 200109281928.f8SJSKP13298@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
> Justin <justin(at)postgresql(dot)org> writes:
> > If there's really something fundamentally wrong with this idea, then
> > let's only do the necessary ones.
> 
> No, nothing fundamentally wrong.  I just prefer to avoid unnecessary
> notational clutter.  Your approach of "let's quote *every* shell
> variable" is defensible but I find it a tad over-the-top.  Comes down
> to a judgment call about code legibility, I suppose.

I prefer the quoting all style, though $? is a special case, as is $#,
and $$, which I certainly would not quote.  Up to you guys.  Also, I
like that fact we are cleaning this up.  From my days writing shql, I
always thought quoting behavour should have been the default for
environment variables.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-09-28 19:37:41
Subject: Re: pg_locale (Was: Re: Problem with setlocale (found in libecpg)...)
Previous:From: John GrayDate: 2001-09-28 17:56:26
Subject: Stray file in contrib/xml -please remove

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group