Skip site navigation (1) Skip section navigation (2)

Re: Fix for broken JDBC's getColumn() (take 2)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Vianen, Jeroen van" <jeroen(dot)van(dot)vianen(at)satama(dot)com>
Cc: pgsql-jdbc(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix for broken JDBC's getColumn() (take 2)
Date: 2001-09-27 17:06:50
Message-ID: 200109271706.f8RH6oI20132@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-jdbcpgsql-patches
OK, adding to queue.

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

> Hi,
> 
> What's the status of this patch I sent two weeks ago? I got no reply last
> week for the same question.
> 
> My original mail can be found at
> http://fts.postgresql.org/db/mw/msg.html?mid=1034457
> 
> Thanks,
> 
> 
> Jeroen
> 
> > -----Original Message-----
> > From: Jeroen van Vianen [mailto:jeroen(dot)van(dot)vianen(at)satama(dot)com]
> > Sent: Monday, September 10, 2001 20:01
> > To: pgsql-jdbc(at)postgresql(dot)org; pgsql-patches(at)postgresql(dot)org
> > Subject: [JDBC] Fix for broken JDBC's getColumn() (take 2)
> > 
> > 
> > Hi,
> > 
> > Per the recent discussion there's been some code changes in JDBC's 
> > DatabaseMetaData.getColumn(). I proposed a patch that would 
> > change the 
> > number of queries to find out all columns in a table from 2 * 
> > N + 1 to 1 (N 
> > being the number of columns reported) by using some outer 
> > joins. I also 
> > fixed the fact that getColumns() only returned columns that 
> > had a default 
> > defined. OTOH, I did not use to change the code required for 
> > obtaining a 
> > column's remarks (by using col_description() for 7.2  and 
> > requested by Tom 
> > Lane).
> > 
> > Finally, I have found a way to get all the column details in 
> > a single query 
> > *and* use col_description() for 7.2 servers. A patch is attached. It 
> > overrules Ren? Pijlman's fix for this that was committed just 
> > today, but 
> > still used N + 1 queries (sorry Ren? ;-) )
> > 
> > I also fixed the return values for TABLE_CAT and TABLE_SCHEM 
> > from "" to 
> > null, to be more standard compliant (and requested in Ren?'s 
> > mail found at 
> > http://fts.postgresql.org/db/mw/msg.html?mid=1034253).
> > 
> > As always, the JDBC1 version has not been tested as I have no JDK 1.1 
> > available.
> > 
> > Please review,
> > 
> > 
> > Jeroen
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-09-27 19:37:14
Subject: Re: [PATCHES] Fix for broken JDBC's getColumn() (take 2)
Previous:From: Tom LaneDate: 2001-09-27 16:21:00
Subject: Re: psql microsecond timing patch

pgsql-jdbc by date

Next:From: Barry LindDate: 2001-09-27 17:10:15
Subject: Re: Help: OutOfMemoryError
Previous:From: Matt FairDate: 2001-09-27 15:23:12
Subject: Re: blobs in a client/server environment

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group