Skip site navigation (1) Skip section navigation (2)

Re: JDBC test suite patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Liam Stewart <liams(at)redhat(dot)com>
Cc: pgsql-jdbc(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: JDBC test suite patch
Date: 2001-09-23 04:14:23
Message-ID: 200109230414.f8N4ENx05039@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-jdbcpgsql-patches
Your name has been added to the bottom of the TODO list.

> 
> I tried sending the email to jdbc and patches on the 17th but it didn't get 
> through. I'm attempting again..
> 
> The attached patch is my first run-through of the JDBC test suite. A
> summary of changes:
> 
>  . removal of the tablename property from build.xml
> 
>  . addition of a dropTable method in JDBC2Tests and cleanups of many
> methods in the same
> 
>  . all tests now use non-deprecated assertXYZ methods instead of the
> deprecated assert method
> 
>  . failure in TimestampTest (testSetTimestamp) fixed. The failure is
> because testSetTimestamp was inserting a timestamp with hour 7 but
> checkTimeTest was expecting a timestamp with hour 8. AFAICS, there are
> no issues wrt daylight savings time and timestamps being pushed in and
> pulled out (but more explicit tests should be added in the future)
> 
>  . failure in TimeTest (testGetTime) fixed. Times to be inserted were
> interpreted in the localtime zone but checking was done with the
> assumption that the insertion was done in GMT.
> 
>  . formatting changes in a few of the source files (because I found
> it convenient to have consistent formatting while working on them). The
> formatting is consistent with the new format for java source files in
> PostgreSQL.
> 
> Liam
> 
> -- 
> Liam Stewart :: Red Hat Canada, Ltd. :: liams(at)redhat(dot)com

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Paul A VixieDate: 2001-09-23 05:08:34
Subject: Re: IPv6 Support for INET/CIDR types.
Previous:From: Bruce MomjianDate: 2001-09-23 04:14:11
Subject: Re: pgcrypto update

pgsql-jdbc by date

Next:From: Dongsheng SongDate: 2001-09-24 04:41:44
Subject: Help: OutOfMemoryError
Previous:From: Bruce MomjianDate: 2001-09-23 04:11:11
Subject: Re: JDBC test suite patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group