Skip site navigation (1) Skip section navigation (2)

pgsql/src/interfaces/jdbc/org/postgresql/test/ ...

From: "Marc G(dot) Fournier" <scrappy(at)hub(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql/src/interfaces/jdbc/org/postgresql/test/ ...
Date: 2001-09-10 15:07:58
Message-ID: 200109101507.f8AF7wx14185@hub.org (view raw or flat)
Thread:
Lists: pgsql-committers
CVSROOT:	/home/projects/pgsql/cvsroot
Module name:	pgsql
Changes by:	scrappy(at)hub(dot)org	01/09/10 11:07:58

Modified files:
	src/interfaces/jdbc/org/postgresql/test/jdbc2: 
	                                               DatabaseMetaDataTest.java 

Log message:
	Attached is a patch that fixes DatabaseMetaDataTest in the JDBC
	driver's test suite. With previous patches applied, this reduces
	the number of failures of the test suite from 6 to 4. The patch
	fixes the test case itself, rather than the driver.
	
	Details:
	
	1) The driver correctly provided DatabaseMetaData about the sort
	order of NULLs. This was confirmed by Peter Eisentraut on
	pgsql-hackers. I fixed the test to accept/require the current
	behaviour, and made it dependent on the backend version. See
	nullsAreSortedAtStart(), nullsAreSortedAtEnd(),
	nullsAreSortedHigh() and nullsAreSortedLow().
	
	2) DatabaseMetaData.supportsOrderByUnrelated() correctly
	returned true (an ORDER BY clause can contain columns that are
	not in the SELECT clause), but the test case required false.
	Fixed that.
	
	3) Replaced deprecated assert() of junit.framework.TestCase by
	assertEquals(), assertTrue() and assertNotNull(). This is
	because assert will be a new keyword in Java 1.4.
	
	4) Replaced assert(message,false) by the more elegant
	fail(message).
	
	Regards,
	Ren? Pijlman <rene(at)lab(dot)applinet(dot)nl>


pgsql-committers by date

Next:From: Marc G. FournierDate: 2001-09-10 15:21:20
Subject: pgsql/doc TODO
Previous:From: Marc G. FournierDate: 2001-09-10 15:07:06
Subject: pgsql/src/interfaces/jdbc/org/postgresql Conne ...

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group