Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] CURRENT CVS: MULTIBYTE: CANT CONNECT....

From: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
To: zakkr(at)zf(dot)jcu(dot)cz
Cc: pgman(at)candle(dot)pha(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] CURRENT CVS: MULTIBYTE: CANT CONNECT....
Date: 2001-09-08 14:51:24
Message-ID: 20010908235124X.t-ishii@sra.co.jp (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackerspgsql-patches
> > > > CC=cc CXX=CC ./configure  --prefix=/usr/local/pgsql --enable-syslog \
> > > > 	--with-CXX --with-perl --enable-multibyte --enable-cassert \
> > > > 	--with-includes=/usr/local/include --with-libs=/usr/local/lib \
> > > > 	--enable-debug \
> > > > 	--with-tcl --with-tclconfig=/usr/local/lib \
> > > > 	--with-tkconfig=/usr/local/lib  --enable-locale 
> > > > and when I try to connect to an existing DB, loaded from a pg_dump
> > > > from the previous 7.2devel sources, I get:
> > > > TRAP: Failed Assertion("!(ClientEncoding):", File: "mbutils.c", Line:
> > > > 314)
> > > > !(ClientEncoding) (0) [No such file or directory]
> > > 
> > >  Interesting. I don't know why, but someting don't call
> > > pg_set_client_encoding() before usage encoding routines (maybe
> > > libpq don't set client encoding if it's default SQL_ASCII, but
> > > I'm almost sure that I check this case).
> > > 
> > >  A simple and robus solution is in the begin of mbutils.c set default
> > > ClientEncoding to SQL_ASCII (like default DatabaseEncoding). Bruce, can
> > > you change it? It's one line change. Again thanks.

Karel,

The bug Larry reported seems for such a case of connecting non
existent database. The backend tries to send the error message to the
frontend using pg_server_to_client WITHOUT getting an encoding info
from the database. To fix this Larry's patch or you stat in the
previous mail are sufficient. I will commit the fix.

>  Forget it! A default client encoding must be set by actual database encoding... 

Why? set_default_client_encoding does the job anyway.
--
Tatsuo Ishii

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2001-09-08 15:07:21
Subject: Re: [PATCHES] CURRENT CVS: MULTIBYTE: CANT CONNECT....
Previous:From: Bruce MomjianDate: 2001-09-08 14:30:23
Subject: Re: CURRENT CVS: MULTIBYTE: CANT CONNECT....

pgsql-bugs by date

Next:From: Bruce MomjianDate: 2001-09-08 15:07:21
Subject: Re: [PATCHES] CURRENT CVS: MULTIBYTE: CANT CONNECT....
Previous:From: Bruce MomjianDate: 2001-09-08 14:30:23
Subject: Re: CURRENT CVS: MULTIBYTE: CANT CONNECT....

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-09-08 15:07:21
Subject: Re: [PATCHES] CURRENT CVS: MULTIBYTE: CANT CONNECT....
Previous:From: Bruce MomjianDate: 2001-09-08 14:30:23
Subject: Re: CURRENT CVS: MULTIBYTE: CANT CONNECT....

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group