Skip site navigation (1) Skip section navigation (2)

Re: Patch for jdbc2 ResultSet.java

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Joseph Shraibman <jks(at)selectacast(dot)net>
Cc: Dave Harkness <daveh(at)MEconomy(dot)com>, Barry Lind <barry(at)xythos(dot)com>, pgsql-patches(at)postgresql(dot)org, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Patch for jdbc2 ResultSet.java
Date: 2001-09-07 21:30:01
Message-ID: 200109072130.f87LU1l29116@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-jdbcpgsql-patches
Sorry, I see it now.


> 
> 
> Dave Harkness wrote:
> > At 12:41 PM 9/5/2001, Joseph Shraibman wrote:
> > 
> >> new patch:
> > 
> > 
> > There still seems to be an error with the same if-block.
> > 
> > !       if (index>=-rows.size())
> > !       internalIndex=rows.size()+index;
> > 
> > becomes
> > 
> > !       if (index > -rows_size)
> > !       internalIndex = rows_size+index;
> > 
> > Note that the original used >=, not >.
> 
> Argh!  I need a better screen. :(
> > 
> > Also, why is the first edit being done? Granted it's faster in that it 
> > doesn't null out the array of rows, but won't that have other effects? 
> 
> No.  Nulling out the array is pointless.
> 
> 
> 
> 
> -- 
> Joseph Shraibman
> jks(at)selectacast(dot)net
> Increase signal to noise ratio.  http://www.targabot.com
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-09-07 21:30:09
Subject: Re: [PATCHES] Patch for jdbc2 ResultSet.java
Previous:From: Bruce MomjianDate: 2001-09-07 21:29:30
Subject: Re: Patch for jdbc2 ResultSet.java

pgsql-jdbc by date

Next:From: Bruce MomjianDate: 2001-09-07 21:30:09
Subject: Re: [PATCHES] Patch for jdbc2 ResultSet.java
Previous:From: Bruce MomjianDate: 2001-09-07 21:29:30
Subject: Re: Patch for jdbc2 ResultSet.java

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group