Re: Another pgindent request

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Another pgindent request
Date: 2001-09-04 03:05:54
Message-ID: 200109040305.f8435sw14790@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Already handled. I ran it on proc.c and got:

MyProc->errType = STATUS_OK; /* initialize result for success */

The feature was added with:

# add space after comments that start on tab stops
sed 's,;\(/\*.*\*/\)$,; \1,' |

I must have added this since 7.1, probably because of a mention from
you.

> As long as you're hacking pgindent, can you do something about its habit
> of sometimes removing all space before a same-line comment? Here's
> an example from the 7.1 run (in src/backend/storage/lmgr/proc.c):
>
> ***************
> *** 607,613 ****
> MyProc->waitHolder = holder;
> MyProc->waitLockMode = lockmode;
>
> ! MyProc->errType = STATUS_OK; /* initialize result for success */
>
> /* mark that we are waiting for a lock */
> waitingForLock = true;
> --- 612,618 ----
> MyProc->waitHolder = holder;
> MyProc->waitLockMode = lockmode;
>
> ! MyProc->errType = STATUS_OK;/* initialize result for success */
>
> /* mark that we are waiting for a lock */
> waitingForLock = true;
> ***************
>
> IMHO there should always be at least one space before a same-line
> comment.
>
> regards, tom lane
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-09-04 03:09:29 Re: Another pgindent request
Previous Message Tom Lane 2001-09-04 03:00:52 Another pgindent request