Re: Any patches to 7.1.3 ?

Rony,

On Mon, Sep 03, 2001 at 10:10:48AM +0200, Ronald Kuczek wrote:
> I'm sorry , I'm writing direct to you - but I need info so quick as possible
> and I know, you are the right man.
> I have installed newest cygwin and cygipc stuff and try to compile
> Postgresql 7.1.3.
> My problem:
> gcc -O2 -Wall -Wmissing-prototypes -Wmissing-declarations command.o
> common.o help.o input.o stringutils.o mainloop.o copy.o startup.o prompt.o
> variables.o large_obj.o print.o describe.o tab-complete.o
> -L../../../src/interfaces/libpq -lpq -L/usr/local/lib -g -lz -lcrypt
> -lreadline -lcygipc -o psql
> tab-complete.o(.text+0x2a36):tab-complete.c: undefined reference to
> `filename_co mpletion_function'
> collect2: ld returned 1 exit status
> [snip]
> make: *** [all] Error 2
>
> Do you know the solution ?

Yes, see below...

On Mon, Sep 03, 2001 at 10:50:04AM +0200, Ronald Kuczek wrote:
> I found the solution. I had to change in file tab-complete.c
> filename_completion_function into rl_filename_completion_function.
> It works now !

I'm glad that you solved your problem. However, the following posting
(with patch) is a better solution because it deals with both readline 4.1
(and older) and readline 4.2 (and newer):

http://fts.postgresql.org/db/mw/msg.html?mid=1030331

This patch has been already accepted into PostgreSQL CVS. Note that it
has been very slightly modified due to the needs of another platform.

BTW, why don't you use my pre-built PostgreSQL 7.1.3 that is part of
the standard Cygwin distribution? Does it not meet your needs?

In the future, please post to pgsql-cygwin(at)postgresql(dot)org instead of
sending private email so others can benefit too.

Thanks,
Jason