Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Patch for broken JDBC's getColumn()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jeroen van Vianen <jeroen(at)vanvianen(dot)nl>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: [PATCHES] Patch for broken JDBC's getColumn()
Date: 2001-08-30 22:57:26
Message-ID: 200108302257.f7UMvQi10579@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-jdbcpgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

	http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

> Hi,
> 
> Attached is a patch for JDBC's getColumn() function that was broken / 
> flawed in the following ways:
> 
> 1. Only returned columns that had a default value defined, rather than all 
> columns in a table
> 2. Used 2 * N + 1 queries to find out attributes, comments and typenames 
> for N columns.
> 
> By using some outer join syntax it is possible to retrieve all necessary 
> information in just one SQL statement. This means this version is only 
> suitable for PostgreSQL >= 7.1. Don't know whether that's a problem.
> 
> I've tested this function with current sources and 7.1.3 and patched both 
> jdbc1 and jdbc2. I haven't compiled nor tested the jdbc1 version though, as 
> I have no JDK 1.1 available.
> 
> Note the discussion in http://fts.postgresql.org/db/mw/msg.html?mid=1029626 
> regarding differences in obtaining comments on database object in 7.1 and 
> 7.2. I was unable to use the following syntax (or similar ones):
> 
> select
>      ...,
>      description
> from
>      ...
>      left outer join col_description(a.attrelid, a.attnum) description
> order by
>      c.relname, a.attnum;
> 
> (the error was parse error at or near '(') so I had to paste the actual 
> code for the col_description function into the left outer join. Maybe 
> someone who is more knowledgable about outer joins might provide me with a 
> better SQL statement.
> 
> Please review.
> 
> Regards,
> 
> 
> Jeroen

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-08-30 22:59:47
Subject: Re: ADD CONSTRAINT UNIQUE patch
Previous:From: Peter EisentrautDate: 2001-08-30 13:22:06
Subject: Re: psql tab completion patch

pgsql-jdbc by date

Next:From: Dave CramerDate: 2001-08-31 00:50:54
Subject: Read transactions don't work on 7.0.x db's
Previous:From: Isabelle TherrienDate: 2001-08-30 22:24:30
Subject: truncated InputStream returned with getAsciiInputStream()

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group