Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Prevent pg_dump running out of memory

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Prevent pg_dump running out of memory
Date: 2001-08-27 15:06:22
Message-ID: 20010828010622.D32309@svana.org (view raw or flat)
Thread:
Lists: pgsql-patches
On Mon, Aug 27, 2001 at 10:42:34AM -0400, Tom Lane wrote:
> Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> > [ use a cursor for pg_dump -d ]
> 
> Excellent idea.  Thanks!

No problems.

> > Also, it seems there is no regression test for pg_dump. Is this intentional
> > or has noone come up with a good way to test it?
> 
> The latter.  We certainly need one...

The only thing I can think of right now is for other parts of the regression
tests to leave various tables, triggers, etc lying around. Then somewhere
near the end, do a pg_dump regress | psql newdb (for various options of
pg_dump) and then somehow compare the two databases.

The comparison would be the tricky part because you should avoid using
pg_dump since that is what you are testing...

-- 
Martijn van Oosterhout <kleptog(at)svana(dot)org>
http://svana.org/kleptog/
> It would be nice if someone came up with a certification system that
> actually separated those who can barely regurgitate what they crammed over
> the last few weeks from those who command secret ninja networking powers.

In response to

pgsql-patches by date

Next:From: David DaneyDate: 2001-08-27 17:18:42
Subject: Re: [JDBC] Re: Bug #428: Another security issue with the JDBC driver.
Previous:From: Tom LaneDate: 2001-08-27 14:42:34
Subject: Re: [PATCH] Prevent pg_dump running out of memory

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group