Re: [PATCHES] encoding names

From: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgman(at)candle(dot)pha(dot)pa(dot)us, barry(at)xythos(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] encoding names
Date: 2001-08-27 07:26:17
Message-ID: 20010827092617.A18762@zf.jcu.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Fri, Aug 24, 2001 at 09:29:06PM +0200, Peter Eisentraut wrote:
> Tatsuo Ishii writes:
>
> > > Maybe we should not touch getdatabaseencoding() right now, given that the
> > > names we currently use are apparently almost correct anyway and
> > > considering the pain it creates to alter them, and instead implement the
> > > information schema views in the future?
> >
> > I thought schema stuffs would be introduced in 7.2 but apparently it
> > would not happen...
>
> True, but right now we'd have to do rather elaborate changes just to
> switch a couple of names to "more correct" versions. Accepting them as
> input is good, but maybe we should hold back on the output part a bit
> until we can do it correctly.

Change output is a very easy work (edit strings in one array). The
important thing is clean internal code for encoding names to faster
and non-duplicated code (use same code for FE and BE).

Well, I prepare it with total back compatible output for all current
routines (pg_char_to_encoding too) and new names will visible by new
routines only (suggested database_character_set(), etc). Right?

Karel

--
Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
http://home.zf.jcu.cz/~zakkr/

C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Karel Zak 2001-08-27 07:54:50 Re: [PATCHES] Re: Re: nocreatetable for 7.1.2 [patch]
Previous Message Tom Lane 2001-08-27 04:16:15 Re: pg_dump failure, can't get data out...

Browse pgsql-patches by date

  From Date Subject
Next Message Karel Zak 2001-08-27 07:54:50 Re: [PATCHES] Re: Re: nocreatetable for 7.1.2 [patch]
Previous Message Larry Rosenman 2001-08-27 07:20:36 official submission for OU8/UnixWare sharedlib patch