Re: Re: [PATCHES] Makefile.PL for Pg.so

From: Larry Rosenman <ler(at)lerctr(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Lamar Owen <lamar(dot)owen(at)wgcr(dot)org>, PostgreSQL Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [PATCHES] Makefile.PL for Pg.so
Date: 2001-08-26 17:48:11
Message-ID: 20010826124810.A27782@lerami.lerctr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

* Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> [010826 11:11]:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Another fun feature of the DESTDIR build environment is that the
> > writability test of the target directory will most likely fail because it
> > doesn't exist at all.
>
> > I've been thinking how I'd like to fix this: We add an option to
> > configure that says to *not* install the Perl module into the standard
> > Perl tree, but instead somewhere under our own $prefix. That way people
> > that don't have root access can use this option and still install the
> > whole tree in one run. But then we'd remove that writability check and
> > people that have root access or failed to use that option will get a hard
> > failure. This would create a much more reliable and predictable build
> > environment.
>
> Why would we remove the writability check? Perhaps it needs to be
> extended to recognize the case of target-dir-doesn't-exist-but-can-be-
> created, but I don't see why a hard failure is better.
I tend to agree with Tom here. The original problem I was seeing is
*NOT* related to DESTDIR (I don't believe).

CC=cc CXX=CC ./configure --prefix=/usr/local/pgsql --enable-syslog \
--with-CXX --with-perl --enable-multibyte --enable-cassert \
--with-includes=/usr/local/include --with-libs=/usr/local/lib \
--enable-debug \
--with-tcl --with-tclconfig=/usr/local/lib \
--with-tkconfig=/usr/local/lib --enable-locale --with-python

The above is my configure input.
>
> regards, tom lane

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Trond Eivind =?iso-8859-1?q?Glomsr=F8d?= 2001-08-26 18:46:54 Re: Re: [PATCHES] Makefile.PL for Pg.so
Previous Message Bruce Momjian 2001-08-26 16:49:22 Re: C++ and bool constants (was Re: [NOVICE] gcc 3.0.1)

Browse pgsql-patches by date

  From Date Subject
Next Message Rene Pijlman 2001-08-26 18:41:37 JDBC Statement.executeBatch patch
Previous Message Bruce Momjian 2001-08-26 17:09:29 Re: [JDBC] Re: Bug #428: Another security issue with the JDBC driver.