Skip site navigation (1) Skip section navigation (2)

Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal support

From: Vsevolod Lobko <seva(at)sevasoft(dot)kiev(dot)ua>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal support
Date: 2001-08-24 09:49:19
Message-ID: 20010824124135.R46106-200000@localhost (view raw or flat)
Thread:
Lists: pgsql-patches
On Thu, 23 Aug 2001, Tom Lane wrote:

> > Is this looks better?
>
> It does, but one small gripe: the lack of semicolons will probably cause
> pg_indent to mess up the indentation.  (I know emacs' autoindent mode
> will not work nicely with it, either.)  Please set up the macros so that
> you write
>
>                         UTF_BEGIN;
>                         Tcl_DStringAppend(&unknown_src, UTF_E2U(part), -1);
>                         UTF_END;
>
> and then I'll be happy.

Attached revised patch

> Your point about overhead is a good one, so I retract the gripe about
> using a configure switch.  But please include documentation patches to
> describe the configure option in the administrator's guide (installation
> section).

This patch still uses configure switch for enabling feature.

For enabling based on tcl version we have 2 posibilites:
 1) having feature enabled by default, but in pltcl.c check for tcl
    version and disable it for old versions
 2) enable or disable at configure time based on tcl version, but there
    are problem - current configure don't checks for tcl version at all
    and my configure skills not enought for adding this

Attachment: tcl_utf.patch
Description: text/plain (6.7 KB)

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-08-24 14:43:19
Subject: Re: [PATCHES] encoding names
Previous:From: Tatsuo IshiiDate: 2001-08-24 04:21:03
Subject: Re: [PATCHES] encoding names

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group