Skip site navigation (1) Skip section navigation (2)

Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal support

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Vsevolod Lobko <seva(at)sevasoft(dot)kiev(dot)ua>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal support
Date: 2001-08-23 17:58:15
Message-ID: 200108231758.f7NHwGK21448@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
> > It adds new configure switch
> > --enable-pltcl-utf. Without this switch patch does nothing.
> 
> This is not a good approach, since it relies on the user to know whether
> he needs to do this or not.  Seems like looking at the Tcl version
> number would be more appropriate: if version >= 8.3 then make these
> changes.  You could do that in the code, without any configure patch,
> using #if's on TCL_MAJOR_VERSION and TCL_MINOR_VERSION (see libpgtcl
> for examples).

I asked him this already and he said that there is extra overhead for
the conversion that many wouldn't want.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Vsevolod LobkoDate: 2001-08-23 17:58:19
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal support
Previous:From: Vsevolod LobkoDate: 2001-08-23 17:30:45
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group