Skip site navigation (1) Skip section navigation (2)

Re: encoding names

From: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
To: peter_e(at)gmx(dot)net
Cc: zakkr(at)zf(dot)jcu(dot)cz, pgman(at)candle(dot)pha(dot)pa(dot)us, barry(at)xythos(dot)com, pgsql-patches(at)postgresql(dot)org
Subject: Re: encoding names
Date: 2001-08-23 00:55:06
Message-ID: 20010823095506U.t-ishii@sra.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> Tatsuo Ishii writes:
> 
> > I don't think you need to change the function name "getdbencoding".
> > "get_canonical_database_encoding" is too long anyway.
> 
> But getdbencoding isn't semantically different from the old
> getdatabaseencoding.  "encoding" isn't the right term anyway, methinks, it
> should be "character set".  So maybe database_character_set()?  (No "get"
> please.)

I'm not a native English speaker, so please feel free to choose more
appropriate name.

BTW, what's wrong with "encoding"? I don't think, for example EUC-JP
or utf-8, are character set names.
--
Tatsuo Ishii

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2001-08-23 00:55:56
Subject: Re: libpq.dll & psql.exe on Win32
Previous:From: Tom LaneDate: 2001-08-23 00:41:22
Subject: Re: GiST patches for 7.2 (please apply)

pgsql-patches by date

Next:From: Karel ZakDate: 2001-08-23 07:22:36
Subject: Re: encoding names v2.
Previous:From: Tatsuo IshiiDate: 2001-08-23 00:54:53
Subject: Re: encoding names v2.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group