Skip site navigation (1) Skip section navigation (2)

Re: libpgtcl doesn't use UTF encoding of TCL

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Reinhard Max <max(at)suse(dot)de>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, elf(at)solvo(dot)ru, pgsql-bugs(at)postgresql(dot)org
Subject: Re: libpgtcl doesn't use UTF encoding of TCL
Date: 2001-07-20 15:17:26
Message-ID: 200107201517.f6KFHQC14099@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackerspgsql-interfaces
> On Fri, 20 Jul 2001, Peter Eisentraut wrote:
> 
> > Reinhard Max writes:
> >
> > > OK, I'll pack the new stuff inside #ifdef TCL_UTF8 and define that if
> > > the Tcl version is 8.1 or greater.
> >
> > No, please add a configure check for Tcl_UtfToExternalDString or
> > some other function representative of this interface..
> 
> Why make simple things complicated?
> Tcl changed it's internal string representation starting with release
> 8.1 . It is not an interface one can decide whether to use it or not.
> Every extension that imports or exports strings and gets compiled for
> Tcl >= 8.1 has to make sure that they are UTF8 regardless, if it uses
> the Tcl_*Utf*DString functions or something else. So I consider it
> sufficient to define TCL_UTF8 if Tcl's Version is >= 8.1 as I did in
> the patch that was attached to my last mail.

I think he is OK checking the TCL version.  It is pretty common to check
the TCL include file for symbols and handle things that way.  Do we test
any other TCL include defines from configure?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-hackers by date

Next:From: Lamar OwenDate: 2001-07-20 15:17:29
Subject: Re: Re: hub.org out of disk space
Previous:From: Bruce MomjianDate: 2001-07-20 15:16:16
Subject: Re: libpgtcl doesn't use UTF encoding of TCL

pgsql-bugs by date

Next:From: Tom LaneDate: 2001-07-20 16:05:37
Subject: Re: check contraint allows illegal value?
Previous:From: Bruce MomjianDate: 2001-07-20 15:16:16
Subject: Re: libpgtcl doesn't use UTF encoding of TCL

pgsql-interfaces by date

Next:From: Mihai GheorghiuDate: 2001-07-20 16:51:25
Subject: Re: URGENT - How to export data from EXCEL to Postgr eSQL ou pgaccess as you want...
Previous:From: Bruce MomjianDate: 2001-07-20 15:16:16
Subject: Re: libpgtcl doesn't use UTF encoding of TCL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group