Re: Python (PyGreSQL) make install patch

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Python (PyGreSQL) make install patch
Date: 2001-07-10 20:00:54
Message-ID: 20010710160054.C320@dothill.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Peter,

On Tue, Jul 10, 2001 at 06:38:31PM +0200, Peter Eisentraut wrote:
> Jason Tishler writes:
>
> > > > [The updated proposed new makefile for interfaces/python is attached.]
>
> > Any status regarding this iteration?
>
> Done now.

Thanks. I just did a cvs update, make distclean, configure ..., make
and PyGreSQL built under Cygwin without any problems.

However, I was a little surprised that you let the following Cygwin
specific code:

ifeq ($(PORTNAME), win)
override CPPFLAGS += -DUSE_DL_IMPORT
SHLIB_LINK += $(python_libspec)
endif

escape from its normal maximum security prison cell (aka Makefile.win).
Shouldn't the above stuff be denied parole and locked up again? :,)

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: 732.264.8770 x235
Dot Hill Systems Corp. Fax: 732.264.8798
82 Bethany Road, Suite 7 Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Ned Wolpert 2001-07-10 20:21:47 RE: Re: Shutdown hook imp
Previous Message Peter Eisentraut 2001-07-10 19:47:47 Time to read pg_hba.conf (Re: [PATCHES] [PATCH] Patch to make...)