Skip site navigation (1) Skip section navigation (2)

Re: encode in base code

From: Marko Kreen <marko(at)l-t(dot)ee>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: encode in base code
Date: 2001-07-03 06:55:29
Message-ID: 20010703085529.A1956@l-t.ee (view raw or flat)
Thread:
Lists: pgsql-patches
On Mon, Jul 02, 2001 at 07:50:45PM +0200, Peter Eisentraut wrote:
> Marko Kreen writes:
> > Put encode() into base system.  Used part of Alex' patch
> > for docs, hope he does not mind ;)
> 
> Please use #include "", not #include <>, for PostgreSQL's header files.
> 
> Would you mind changing the copyright to match the rest of the source?
> 
> Put everything in encode.c (not varlena.c), and put encode.c in utils/adt.
> 
> I think we've covered before that 'uint' is not a standard data type.
> VARSIZE is of type int32 (signed).
> 
> To convert from text to C string, use textout().
> 
> Also, I think the term "encode" is already overloaded for multibyte use.
> Maybe it needs to be qualified, such as "binary_encode".

Used 'unsigned' in encoding code.

-- 
marko


Attachment: enc2.diff.gz
Description: application/octet-stream (3.2 KB)

In response to

Responses

pgsql-patches by date

Next:From: Damien ClermontéDate: 2001-07-03 15:17:08
Subject: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword
Previous:From: Marko KreenDate: 2001-07-02 19:36:47
Subject: Re: encode in base code

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group